Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): protocol engine command for identifying module (w/ stacker implementation) #17951

Open
wants to merge 5 commits into
base: edge
Choose a base branch
from

Conversation

ahiuchingau
Copy link
Contributor

Overview

This PR introduces the identifyModule command to the protocol engine, allowing hardware modules to be identified by module model and module ID. Currently, the identify function is only implemented for the stacker.

@ahiuchingau ahiuchingau requested review from a team as code owners April 1, 2025 18:15
@ahiuchingau ahiuchingau force-pushed the EXEC-1229_identify-stacker branch from 3b00311 to 67c2896 Compare April 1, 2025 18:16
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.81%. Comparing base (14ee9f8) to head (92a2149).
Report is 5 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17951       +/-   ##
===========================================
- Coverage   62.01%   22.81%   -39.21%     
===========================================
  Files        2989     2989               
  Lines      232004   232810      +806     
  Branches    20013    19751      -262     
===========================================
- Hits       143885    53116    -90769     
- Misses      87942   179683    +91741     
+ Partials      177       11      -166     
Flag Coverage Δ
app 0.34% <ø> (-47.37%) ⬇️
protocol-designer 18.87% <ø> (ø)
step-generation 4.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1752 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddcc4
Copy link
Contributor

ddcc4 commented Apr 1, 2025

Drive-by comment: What will show up in the run log and in simulate if this command is used?

@ahiuchingau ahiuchingau force-pushed the EXEC-1229_identify-stacker branch from 67c2896 to 6aad680 Compare April 8, 2025 21:14
@ahiuchingau
Copy link
Contributor Author

Drive-by comment: What will show up in the run log and in simulate if this command is used?

I'm not sure actually. We are planning on using this command only during a module attach flow on the app/odd. Do you think it should show up in the run log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants