Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): refactor Helix components #17995

Draft
wants to merge 6 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 7, 2025

Overview

refactor Helix components

close AUTH-1682

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 45.83333% with 52 lines in your changes missing coverage. Please review.

Project coverage is 26.53%. Comparing base (7c1947c) to head (f32848d).

Files with missing lines Patch % Lines
components/src/atoms/Chip/index.tsx 12.12% 29 Missing ⚠️
components/src/atoms/StepMeter/index.tsx 15.78% 16 Missing ⚠️
components/src/atoms/ListButton/index.tsx 88.57% 4 Missing ⚠️
.../src/pages/Desktop/Devices/RobotSettings/index.tsx 0.00% 2 Missing ⚠️
app/src/pages/Desktop/AppSettings/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17995       +/-   ##
===========================================
- Coverage   61.74%   26.53%   -35.22%     
===========================================
  Files        2967     2966        -1     
  Lines      229256   229048      -208     
  Branches    19489    19370      -119     
===========================================
- Hits       141555    60767    -80788     
- Misses      87524   168260    +80736     
+ Partials      177       21      -156     
Flag Coverage Δ
protocol-designer 18.80% <44.79%> (-0.02%) ⬇️
step-generation 4.40% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ms/ListItem/ListItemChildren/ListItemCustomize.tsx 78.72% <100.00%> (ø)
...s/ListItem/ListItemChildren/ListItemDescriptor.tsx 95.65% <ø> (ø)
app/src/pages/Desktop/AppSettings/index.tsx 0.00% <0.00%> (-95.75%) ⬇️
.../src/pages/Desktop/Devices/RobotSettings/index.tsx 0.00% <0.00%> (-87.74%) ⬇️
components/src/atoms/ListButton/index.tsx 95.69% <88.57%> (+0.51%) ⬆️
components/src/atoms/StepMeter/index.tsx 14.70% <15.78%> (+7.29%) ⬆️
components/src/atoms/Chip/index.tsx 74.33% <12.12%> (-25.67%) ⬇️

... and 1624 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant