Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): finish logic for liquid class getter #18035

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

fix(protocol-designer): add retract and submerge positions to no liqu…

bf410a9
Select commit
Loading
Failed to load commit list.
Open

feat(protocol-designer): finish logic for liquid class getter #18035

fix(protocol-designer): add retract and submerge positions to no liqu…
bf410a9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 10, 2025 in 0s

62.88% (+38.47%) compared to 16b1ff5

View this Pull Request on Codecov

62.88% (+38.47%) compared to 16b1ff5

Details

Codecov Report

Attention: Patch coverage is 8.34725% with 549 lines in your changes missing coverage. Please review.

Project coverage is 62.88%. Comparing base (16b1ff5) to head (bf410a9).
Report is 8 commits behind head on edge.

Files with missing lines Patch % Lines
...r/src/steplist/formLevel/handleFormChange/utils.ts 8.08% 500 Missing ⚠️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.00% 20 Missing ⚠️
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx 0.00% 15 Missing ⚠️
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx 0.00% 12 Missing ⚠️
...er/src/components/organisms/ResetSettingsModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18035       +/-   ##
===========================================
+ Coverage   24.40%   62.88%   +38.47%     
===========================================
  Files        2973     2990       +17     
  Lines      229681   232859     +3178     
  Branches    19299    20459     +1160     
===========================================
+ Hits        56060   146423    +90363     
+ Misses     173609    86259    -87350     
- Partials       12      177      +165
Files with missing lines Coverage Δ
...m/StepTools/MoveLiquidTools/ResetSettingsField.tsx 100.00% <100.00%> (ø)
...er/src/components/organisms/ResetSettingsModal.tsx 3.50% <0.00%> (ø)
...esigner/ProtocolSteps/StepForm/StepFormToolbox.tsx 5.51% <0.00%> (ø)
...StepForm/StepTools/MixTools/SecondStepMixTools.tsx 0.85% <0.00%> (-0.06%) ⬇️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.61% <0.00%> (-0.02%) ⬇️
...r/src/steplist/formLevel/handleFormChange/utils.ts 19.27% <8.08%> (-12.38%) ⬇️

... and 1696 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov