Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Enable Platform Sensor position validation for Move Labware and Stacker actions #18040

Open
wants to merge 5 commits into
base: edge
Choose a base branch
from

Conversation

CaseyBatten
Copy link
Contributor

@CaseyBatten CaseyBatten commented Apr 10, 2025

Overview

Covers EXEC-1280

Previously we only checked the stackers Retracted position because the EVT models did not have the capability to utilize the sensor in the Extended position. We also did not validate the carriage was actually in the Extended position for any Move Labware commands relating to the stacker either prior. This PR rectifies both of those.

Test Plan and Hands on Testing

  • Unit tests covering move labware
  • Operational tests on Flex hardware with EVTs ensuring we skip the extended check on them
  • Operational tests on Flex hardware with DVTs ensuring we DO NOT skip the extended check on their actions

Changelog

Added Extended position validation to the stacker plan for action steps
Added validation exceptions for EVT units
Added validation calls to move labware to give stacker special case coverage

Review requests

Any weird edge cases missed where we'll need to validated the stacker as a location first? Maybe load labware?

Risk assessment

Low - new behavior validation that we sidestepped earlier due to technical limitations

@CaseyBatten CaseyBatten requested a review from a team as a code owner April 10, 2025 20:32
@CaseyBatten CaseyBatten requested a review from ahiuchingau April 10, 2025 21:35
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (14ee9f8) to head (895ae5f).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18040   +/-   ##
=======================================
  Coverage   62.01%   62.01%           
=======================================
  Files        2989     2989           
  Lines      232004   232004           
  Branches    20013    20013           
=======================================
  Hits       143885   143885           
  Misses      87942    87942           
  Partials      177      177           
Flag Coverage Δ
protocol-designer 18.87% <ø> (ø)
step-generation 4.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant