Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): skip transfers if volume is zero, improve error when out of tips #18042

Open
wants to merge 4 commits into
base: chore_release-8.4.0
Choose a base branch
from

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Apr 11, 2025

Closes AUTH-1579, AUTH-1622

Overview

Implements following-

  • skip transfers if transfer volume is zero
  • when a transfer runs out of tips, don't print out the full verbose tiprack location. Just the tiprack names + slots

Test Plan and Hands on Testing

Added an integration test. Will be tested further during QA

Review requests

  • usual code quality stuff

Risk assessment

Low. Error text related fixes only

@sanni-t sanni-t requested a review from a team as a code owner April 11, 2025 03:58
@sanni-t sanni-t requested a review from jbleon95 April 11, 2025 16:38
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.58%. Comparing base (53b2e87) to head (8f1bdd9).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #18042      +/-   ##
=======================================================
- Coverage                28.86%   27.58%   -1.29%     
=======================================================
  Files                     3106     3106              
  Lines                   235805   235785      -20     
  Branches                 19121    19121              
=======================================================
- Hits                     68074    65043    -3031     
- Misses                  167707   170719    +3012     
+ Partials                    24       23       -1     
Flag Coverage Δ
app 1.33% <ø> (-1.88%) ⬇️
protocol-designer 18.78% <ø> (ø)
step-generation 4.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant