-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol-designer): use deckConfigurator for hardware onboarding page #18044
base: edge
Are you sure you want to change the base?
Conversation
|
Screen.Recording.2025-04-11.at.3.08.07.PM.movafter adding a module to B1, if i click on A1, TC shows up in the modal. when i select that, it seems to override and remove button isn't responded. is this expected? |
protocol-designer/src/components/organisms/HardwareConfigurator/AddFixtureModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/organisms/HardwareConfigurator/AddFixtureModal.tsx
Outdated
Show resolved
Hide resolved
@koji - overriding is expected. But you should be able to to still remove the thermocycler. i'll look into it. thanks for catching! |
@koji yeah, we want the plate reader to always show up but when you click to add it, a snackbar appears if you don't have a gripper attached. this is Sue's request |
closes AUTH-1706
Overview
This is a huge PR which refactors how we add modules and fixtures to the onboarding flow for the Flex. The ot-2 pretty much stays the same.
Test Plan and Hands on Testing
Test the onboarding flow and make sure everything works as expected when adding the different module combos and fixtures
There are 3 snackbars you should run into:
And then you should run into a snackbar if you try to confirm and proceed when there is no trash bin or waste chute
Changelog
fixtures
andhasGripper
DeckConfigurator
component and make newhardwareConfigurator
and modal and utils to handle adding the different optionsSelectOt2Modules
component to be for ot-2 onlyRisk assessment
medium - touches a lot of the onboarding flow