feat(app): update Select pipette path component #18047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Select pipette path component to align with the design close AUTH-
koji
commented
Apr 11, 2025
|
|
||
| ## [WIP] Version 1.2.0 | ||
|
|
||
| Due to changes in the Quick Transfer setup flow, there will be changes to QuickTransferWizardState and QuickTransferSummaryState. The changes are as follows: |
There was a problem hiding this comment.
i haven't updated QuickTransferSummaryState because we need to keep the current setup flow and summry. the items in QuickTransferWizardState are optional so this change doesn't have any impact on the current setup flow.
koji
commented
Apr 11, 2025
Comment on lines
+98
to
+111
| // ToDo (kk:04/10/2025) uncomment this when add tip frequency | ||
| // case 'SET_CHANGE_TIP': { | ||
| // return { | ||
| // ...state, | ||
| // changeTip: action.changeTip, | ||
| // } | ||
| // } | ||
| // ToDo (kk:04/10/2025) uncomment this when add drop tip location | ||
| // case 'SET_DROP_TIP_LOCATION': { | ||
| // return { | ||
| // ...state, | ||
| // dropTipLocation: action.location, | ||
| // } | ||
| // } |
There was a problem hiding this comment.
these will be uncomment when i add each component.
koji
commented
Apr 11, 2025
| @@ -23,6 +23,8 @@ export interface QuickTransferWizardState { | |||
| destinationWells?: string[] | |||
| transferType?: TransferType | |||
| volume?: number | |||
| // Note added for liquid classes in Quick Transfer | |||
There was a problem hiding this comment.
this comment will be removed when ff is removed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update Select pipette path component to align with the design
close AUTH-1003
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low