This repository was archived by the owner on Jan 2, 2019. It is now read-only.
Excel2007 disk cache #353
Open
Excel2007 disk cache #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHP XMLWriter class doesn't automatically flush out the generated XML document into the associated files. As the code doesn't explicitely call the "flush()" method anywhere, it means the document is only flushed once, when closing the document. To make disk caching effective in reducing memory usage, this commit overrides some methods of XMLWriter in order to trigger an automatic flush every 100 XML elements, in order to keep the memory used by the XMLWriter as low as possible.
The purpose is to track the generated file names and "garbage collect" them at once.
…mory. The potential gain in memory usage offered by disk caching was annihilated by the fact that the generated content was read into memory before being added to the archive.
When we have a file name for the image being added to the ZIP file, there is no need to read it into memory.
This is to improve readability.
This reduces code duplication among the various parts.
XMLWriter now takes the temporary file name as an argument, allowing us to make a better management of the temporary files though the tracker object. This allows us to manage the lifetime of the various temporary files more easily.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits reduce the memory usage due to disk caching in the Excel2007 writer by ensuring that:
The PCLZip compatibility is lame and can probably be enhanced...