Lrcoutinho slbiag #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GEN_PRIV can't be used in functions that return a value. Add GEN_PRIV2 for this end.
Also decode RIC, PRS and R operands.
Also decode RIC, PRS and R operands.
This initial version supports the invalidation of one or all TLB entries. Flush by PID/LPID, or based in process/partition scope is not supported, because it would make using the generic QEMU TLB implementation hard. In these cases, all entries are flushed.
Implement the following PowerISA v3.0 instuction: slbiag: SLB Invalidate All Global X-form Move the following PowerISA v3.0 instuction to decodetree: slbie: SLB Invalidate Entry X-form slbieg: SLB Invalidate Entry Global X-form slbia: SLB Invalidate All X-form slbmte: SLB Move To Entry X-form slbmfev: SLB Move From Entry VSID X-form slbmfee: SLB Move From Entry ESID X-form slbfee: SLB Find Entry ESID slbsync: SLB Synchronize Signed-off-by: Lucas Coutinho <[email protected]>
|
I think it would be better to split the first commit in 2:
|
luporl
requested changes
May 20, 2022
target/ppc/insn32.decode
Outdated
Comment on lines
208
to
222
| &X_rs_l rs l:bool | ||
| @X_rs_l ...... rs:5 .... l:1 ..... .......... . &X_rs_l | ||
|
|
||
| &X_ih ih:uint8_t | ||
| @X_ih ...... -- ih:3 ----- ----- .......... - &X_ih | ||
|
|
||
| &X_rb rb | ||
| @X_rb ...... ----- ----- rb:5 .......... - &X_rb | ||
|
|
||
| &X_sb rs rb | ||
| @X_sb ...... rs:5 ----- rb:5 .......... - &X_sb | ||
|
|
||
| &X_tb1 rt rb | ||
| @X_tb1 ...... rt:5 ----- rb:5 .......... . &X_tb1 | ||
|
|
There was a problem hiding this comment.
No '-' (dashes) here, only dots
dashes only in the instructions, below
Comment on lines
+488
to
+489
| is == TLBIE_IS_VA) || | ||
| (!prs && is == TLBIE_IS_PID))) { |
There was a problem hiding this comment.
I see your intention with this indentation, but it looks weird
Might be better to remove it and merge the lines
((ric == TLBIE_RIC_PWC || ric == TLBIE_RIC_ALL) &&
is == TLBIE_IS_VA) || (!prs && is == TLBIE_IS_PID))) {
There was a problem hiding this comment.
or even better (if it fits the 80 cols)
if (unlikely(ric == TLBIE_RIC_GRP ||
((ric == TLBIE_RIC_PWC || ric == TLBIE_RIC_ALL) && is == TLBIE_IS_VA) ||
(!prs && is == TLBIE_IS_PID))) {
IIRC the style guide isn't strict about aligning with the most internal parenthesis, so I think we can align with the if parenthesis
There was a problem hiding this comment.
This change actually came from #88. It was already sent to the mailing list.
luporl
reviewed
May 31, 2022
luporl
reviewed
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.