Skip to content

[ci]修复中文 api_label 检查的若干问题 #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

ooooo-create
Copy link
Collaborator

  1. 修复文件是否进行 api_label 检测的判定
  2. 添加文件本身 api_label 检验的特殊情况(Resize__upper_cn.rst等六种情况

link #6226
@SigureMo

@paddle-bot
Copy link

paddle-bot bot commented Oct 22, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6237.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@@ -66,8 +67,8 @@ def find_api_labels_in_one_file(file_path):
def should_test(file):
return (
file.endswith("_cn.rst")
and not file.endswith("Overview_cn.rst")
and not file.endswith("index_cn.rst")
and not file.split('/')[-1] == "Overview_cn.rst"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用 os.path.split 会不会更好些?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

赞同,那这个
1697973865078
是不是也可以改成
result = '_".jion(Path(result).parts) [doge]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯可以的~

@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Oct 22, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants