-
Notifications
You must be signed in to change notification settings - Fork 823
[ci]修复中文 api_label 检查的若干问题 #6237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6237.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
ci_scripts/check_api_label_cn.py
Outdated
@@ -66,8 +67,8 @@ def find_api_labels_in_one_file(file_path): | |||
def should_test(file): | |||
return ( | |||
file.endswith("_cn.rst") | |||
and not file.endswith("Overview_cn.rst") | |||
and not file.endswith("index_cn.rst") | |||
and not file.split('/')[-1] == "Overview_cn.rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里用 os.path.split
会不会更好些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯可以的~
Co-authored-by: Nyakku Shigure <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow 🐾
link #6226
@SigureMo