Skip to content

[Minor] GainSelfHealFromPlayerControl/Allies #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[Minor] GainSelfHealFromPlayerControl/Allies #1581

wants to merge 8 commits into from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Mar 20, 2025 •
edited
Loading

In campaign, whether or not self-healing effects for player can be benefited by houses with PlayerControl=true can be controlled via GainSelfHealFromPlayerControl. Whether or not these effects can be benefited by allied houses can be controlled via GainSelfHealFromAllies.

In rulesmd.ini:

[General]
GainSelfHealFromPlayerControl=false     ; boolean
GainSelfHealFromAllies=false            ; boolean

@github-actions github-actions bot added the Minor Documentation is not required label Mar 20, 2025
@Coronia Coronia added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Mar 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

TaranDahl
TaranDahl approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@TaranDahl TaranDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TaranDahl
Copy link
Contributor

I guess GainSelfHealAllowAlly might also be useful. It is good to make one, if you are interested in it.

@Coronia Coronia force-pushed the self-healing-player-control branch from 7b7d4c3 to f8b4af8 Compare March 20, 2025 04:36
@Coronia Coronia changed the title [Minor] GainSelfHealAllowPlayerControl [Minor] GainSelfHealFromPlayerControl/Allies Mar 20, 2025
@Coronia
Merge remote-tracking branch 'upstream/develop' into self-healing-pla…
2b63b5a 
…yer-control

# Conflicts:
#	docs/Whats-New.md
@Coronia Coronia requested a review from CrimRecya March 28, 2025 02:44
CrimRecya
CrimRecya requested changes Apr 19, 2025
View reviewed changes
Coronia added 2 commits April 20, 2025 11:11
@Coronia
update
6d1af42
@Coronia
Merge remote-tracking branch 'upstream/develop' into self-healing-pla…
6cbcec9 
…yer-control

# Conflicts:
#	CREDITS.md
#	docs/Whats-New.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrimRecya CrimRecya CrimRecya requested changes

@TaranDahl TaranDahl TaranDahl approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Minor Documentation is not required ⚙️T1 T1 maintainer review is sufficient Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coronia @TaranDahl @CrimRecya