Unit & infantry auto-conversion on ammo change

[FS-21]

• Units/infantry can now be converted into another unit/infantry by ammo count.
• Ammo.AutoConvertMinimumAmount determines the minimal number of ammo at which a unit converts automatically.
• Ammo.AutoConvertMaximumAmount determines the maximum number of ammo at which a unit converts automatically.
• Ammo.AutoConvertType specify the new techno after the conversion. This unit must be of the same type of the original (vehicle -> vehicle or infantry -> infantry).
• Setting a negative number will disable ammo count check.

In rulesmd.ini:

[SOMETECHNO]                      ; InfantryType or VehicleType
Ammo.AutoConvertMinimumAmount=-1  ; integer
Ammo.AutoConvertMaximumAmount=-1  ; integer
Ammo.AutoConvertType=             ; InfantryType or VehicleType

• Tested in online games.
• This auto-conversion feature requires Ares.
• Based / Inspired in Frione's work for "vehicle auto-deploy / deploy block on ammo change".

[github-actions]

Nightly build for this pull request:

• compiled-dll-15f2366ef9e3c792e9cdec0914d60a8f93d91810.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Coronia]

Think it's still better to batch these conditional conversion and AutoDeath in a same condition group, so it has the following benefits:

• use same condition calculation logic, so more consistent
• more conditions can be naturally supported by this system

see #1346

[TaranDahl]

Two concerns:

1. Why are the AircraftTypes excluded?
2. The behavior of checking during the techno update does not match the description in the document (on ammo change). I think you should check it when the ammo changes or clarify the actual checking timing in the document.

[FS-21]

Two concerns:

1. Why are the AircraftTypes excluded?
2. The behavior of checking during the techno update does not match the description in the document (on ammo change). I think you should check it when the ammo changes or clarify the actual checking timing in the document.

1. [SOMETECHNO] ; InfantryType or VehicleType <--- do you mean this in the docs? I never tested what happens in AircraftTypes but since it uses the Ares conversion logic is the same case of any aircraft (again, I never tested it on this kind of unit), only infantry & vehicles that was the initial scope of the feature (the additional types are welcome if they are supported without additional code changes).
2. Probably docs confussion but I don't see too much the difference. Modders shouldn't know that the check process is during an internal check done every frame in every techno and is more clear that it happens after the ammo changed the value. Do you have any better idea for changing this text for clarifying the possible confussion?

[FS-21]

Think it's still better to batch these conditional conversion and AutoDeath in a same condition group, so it has the following benefits:

• use same condition calculation logic, so more consistent
• more conditions can be naturally supported by this system

see #1346

We can re-think the code after the merge into develop of #1346 but for now I need this feature for my mod and I share the current implementation :-D

[TaranDahl]

Probably docs confussion but I don't see too much the difference. Modders shouldn't know that the check process is during an internal check done every frame in every techno and is more clear that it happens after the ammo changed the value. Do you have any better idea for changing this text for clarifying the possible confussion?

There is not much difference indeed. I think you just need to additionally explain the actual check process in the document.

[TaranDahl]

[SOMETECHNO] ; InfantryType or VehicleType <--- do you mean this in the docs? I never tested what happens in AircraftTypes but since it uses the Ares conversion logic is the same case of any aircraft (again, I never tested it on this kind of unit), only infantry & vehicles that was the initial scope of the feature (the additional types are welcome if they are supported without additional code changes).

You don't need to worry about ConvertToType. If the conversion can not be processed, it will exit safely.

[TaranDahl]

LGTM. Only one small concern.

[CrimRecya]

const auto pFoot = abstract_cast<FootClass* , true >(pThis); is a method of using encapsulated functions, which can be directly used.

[FS-21]

But you are suggesting a code change or simply explaining a recommendation for future similar situations? is for going direct & closing the pending conversation :-P

[CrimRecya]

You don't need to do sanity check on pThis. You have already used pThis->Ammo and are even still using pThis->GetTechnoType(), it cannot be empty.
I explained for a while just to make you understand what the true in abstract_cast means.

[FS-21]

Ok now I understood, so I'll leave as
const auto pFoot = abstract_cast<FootClass*, true>(pThis);
because as you said pThis was already used and the last bit of information i wanted to know is if pThis is a FootClass object or something else for future things.

[CrimRecya]

if pThis is a FootClass object or something else for future things.

Sorry, I didn't understand what you meant. pThis is a TechnoClass pointer and the converted pFoot is a FootClass pointer. Unless it is not a Foot (such as a Building), they all point to the same entity.