Skip to content

[Minor] User side laser trails switch #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CrimRecya
Copy link
Contributor

@CrimRecya CrimRecya commented May 20, 2025

I'm not sure if CRC is needed, it's best to do a multiplayer online test.

In ra2md.ini:

[Phobos]
EnableLaserTrails=true           ; boolean

@CrimRecya CrimRecya added Needs testing Minor Documentation is not required ⚙️T1 T1 maintainer review is sufficient labels May 20, 2025
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku
Copy link
Contributor

Starkku commented May 20, 2025

User settings like this should be made with the possibility of them being toggleable in-game in mind, even though this is not currently available. All of the existing user option toggles operate under this principle. This currently disables parsing of laser trails, not drawing.

If you only disable drawing it is a purely visual thing that does not affect game state so no additional changes to sync logic are needed.

@CrimRecya
Copy link
Contributor Author

CrimRecya commented May 20, 2025

User settings like this should be made with the possibility of them being toggleable in-game in mind, even though this is not currently available. All of the existing user option toggles operate under this principle. This currently disables parsing of laser trails, not drawing.

If you only disable drawing it is a purely visual thing that does not affect game state so no additional changes to sync logic are needed.

Yes, but I just don't think anyone likes to turn on and off this in the game because those who really need to turn it off may not be able to afford the performance cost on their computer, so skipping from reading is the best performance solution.

If this solution does not meet the requirements, then forget it.

@Metadorius
Copy link
Member

Doesn't Detail Level slider accomplish the same?

@CrimRecya
Copy link
Contributor Author

CrimRecya commented May 20, 2025

Doesn't Detail Level slider accomplish the same?

People may prefer to turn it off rather than keep that kind of "Laser".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required Needs discussion Needs testing ⚙️T1 T1 maintainer review is sufficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants