New EVA voice after deploying a building #1682
Open
+203
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CanChangeEvaVoice
2025-05-28.09-02-10.mp4 |
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Starkku
requested changes
Jun 13, 2025
There was a problem hiding this comment.
The EVA voice change logic should be generalized and put in a separate function from buildings, probably in SideExt or something. Firestorm has a map trigger for this purpose and I suppose someone might want to reimplement that here as well.
Some smaller things to take note of as well.
Comment on lines
+41
to
+42
| NewEVAVoice= ; boolean | ||
| NewEVAVoice.Index=0 ; integer |
There was a problem hiding this comment.
Get rid of the bool and use Nullable or negative default value index.
Comment on lines
+319
to
+322
| namespace EVAIndexListTemp | ||
| { | ||
| std::vector<std::string> EVAIndexList; | ||
| } |
There was a problem hiding this comment.
Is this namespace actually used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewEVAVoice.Indexis the index of the new EVA voice. Ares is hightly recomended because these indexes are readed the new section[EVATypes]atevamd.inicreated by Ares. Look at Ares documentation for more information.NewEVAVoice.Priorityestablish a priority queue, being the highest value the selected one.NewEVAVoice.RecheckOnDeathre-checks a new EVA voice after the destruction/undeployment of of of these buildings.NewEVAVoice.InitialMessageplays an EVA message to the player when a different EVA has been selected.In
rulesmd.ini: