Skip to content

[Minor] Fix ForceWeapon.InRange not taking effect when attacking non-techno #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2025

Conversation

CrimRecya
Copy link
Contributor

@github-actions github-actions bot added the Minor Documentation is not required label Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d better to add a tag to customize whether ForceWeapon.InRange should affect empty ground, cuz 1) other ForceWeapon doesn’t really work on empty ground, so this is an exception, and 2) there’re cases when modders only want to use it on units only

@CrimRecya CrimRecya requested a review from Coronia June 3, 2025 17:32
Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doc for ForceWeapon.InRange.TechnoOnly and we're good

@Coronia Coronia force-pushed the develop-FcWpInRangeFix branch from 18d4476 to 15079f0 Compare June 4, 2025 12:29
@Coronia Coronia merged commit deecb4c into Phobos-developers:develop Jun 4, 2025
6 checks passed
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Jun 5, 2025
@CrimRecya CrimRecya deleted the develop-FcWpInRangeFix branch June 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants