Skip to content

Fix functions that return structs to return structs, not pointers #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ZivDero
Copy link
Contributor

@ZivDero ZivDero commented Jun 8, 2025

Fixes functions that return CoordStruct, CellStruct or Matrix3D by value to actually do that, and dump the wrappers.
Needs to be tested, also BuildingClass_GetFireCoords_Wrapper is weird.

Copy link

github-actions bot commented Jun 8, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@ZivDero ZivDero force-pushed the fix-struct-returns-functions branch from 8efc535 to 2f53fb5 Compare June 9, 2025 19:20
@Starkku
Copy link
Contributor

Starkku commented Jun 9, 2025

Any unit/building trying to fire any weapon will crash the game
except.txt
debug.log

@ZivDero
Copy link
Contributor Author

ZivDero commented Jun 9, 2025

Any unit/building trying to fire any weapon will crash the game except.txt debug.log

Will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants