Ground line for select box

[NetsuNegi]

• Grounded has been abandoned, you can now use GroundShape to specific a image which always draw on ground, it will only draw when techno is in air if set Ground.AlwaysDraw=false, this also affect on GroundLine.
• Grounded 已经被废弃了，你现在可以通过 GroundShape 指定一个始终绘制在地面的图像，若 Ground.AlwaysDraw=false ，那么它只会在单位位于空中时绘制，这也影响 GroundLine 的绘制。
• If GroundLine=true , the game will draw a line from techno's position to its vertical projection, GroundLine.Dashed=true means the projection line is a dashed line.
• 若 GroundLine=true ，那么游戏将会绘制一条从单位的位置到其垂直投影的线，GroundLine.Dashed=true 意味着投影线为虚线。

In rulesmd.ini:

[SOMESELECTBOXTYPE] ; Select box Type name
GroundShape=                            ; filename with .shp extension
GroundPalette=palette.pal               ; filename with .pal extension
GroundFrames=                           ; List of integer, default 1,1,1 for infantry, 0,0,0 for vehicle and aircraft
GroundOffset=0,0                        ; integers - horizontal, vertical
Ground.AlwaysDraw=true             ; boolean
GroundLine=false                        ; boolean
GroundLineColor=0,255,0                 ; R, G, B
GroundLineColor.ConditionYellow=        ; R, G, B
GroundLineColor.ConditionRed=           ; R, G, B
GroundLine.Dashed=false                 ; boolean

[github-actions]

Nightly build for this pull request:

• compiled-dll-72d650b3d3c14f417f0f56ac169f5e9ed6a8c1cf.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[Metadorius]

1. Maybe it's better to use a shp to draw ground line? Optionally perhaps. Or somehow make it more tweakable. Maybe some would like a dotted or thicker line or something.
2. Any way to display GroundShape only when flying?
3. This would be a great candidate to add an image to docs.

[NetsuNegi]

• Maybe it's better to use a shp to draw ground line? Optionally perhaps. Or somehow make it more tweakable. Maybe some would like a dotted or thicker line or something.
• Any way to display GroundShape only when flying?
• This would be a great candidate to add an image to docs.

I dont think shp is a good idea, that will make it harder to draw a line which length is changeable

[NetsuNegi]

1. Maybe it's better to use a shp to draw ground line? Optionally perhaps. Or somehow make it more tweakable. Maybe some would like a dotted or thicker line or something.
2. Any way to display GroundShape only when flying?
3. This would be a great candidate to add an image to docs.

GroundShape is designed to draw a different image than Shape. For example, a point. But I still can add a tag to prevent draw it when its height is 0.

[Metadorius]

I dont think shp is a good idea, that will make it harder to draw a line which length is changeable

No way to draw only a part of the SHP?
like imagine a 4px height SHP, and the line is 6px tall, then the SHP will be drawn 1.5 times starting from the top

[Metadorius]

GroundShape is designed to draw a different image than Shape. For example, a point. But I still can add a tag to prevent draw it when its height is 0.

I guess you could use InAir check for this. My thought was so that GroundShape could indicate that the unit is grounded or flying and be only used for the airborne state.

[NetsuNegi]

GroundShape is designed to draw a different image than Shape. For example, a point. But I still can add a tag to prevent draw it when its height is 0.

I guess you could use InAir check for this. My thought was so that GroundShape could indicate that the unit is grounded or flying and be only used for the airborne state.

maybe check height greater than 0 also good?

[Metadorius]

maybe check height greater than 0 also good?

I think it wouldn't be that useful. Hover units would also receive one then, and I don't think it would be beneficial in this case if the modder wants it only for airborne units.

IIRC InAir() determines whether AA weapons can fire on the unit too, so it could be useful for things like helicopters and planes taking off to know whether they are valid AA targets yet (when they take off). So I think it's only logical to tie those together.

[NetsuNegi]

maybe check height greater than 0 also good?

I think it wouldn't be that useful. Hover units would also receive one then, and I don't think it would be beneficial in this case if the modder wants it only for airborne units.

IIRC InAir() determines whether AA weapons can fire on the unit too, so it could be useful for things like helicopters and planes taking off to know whether they are valid AA targets yet (when they take off). So I think it's only logical to tie those together.

alright

[Metadorius]

Huh, I thought this behavior should be controlled via a tag, maybe something like GroundShape.ShowAlways=false. Sorry, should've made it clear initially.

[Metadorius]

Also is it intended that the shadow is drawn over it?

[NetsuNegi]

还有，是否打算在它上面画阴影？

I dont have that plan

[Metadorius]

I dont have that plan

I meant that in your picture it looks like this:

I am not sure if you wanted this

[NetsuNegi]

I dont have that plan

I meant that in your picture it looks like this:

I am not sure if you wanted this

I know, but this may be a bit troublesome

[NetsuNegi]

Huh, I thought this behavior should be controlled via a tag, maybe something like GroundShape.ShowAlways=false. Sorry, should've made it clear initially.

finished

[Speederovsky]

I don't really see the shadow covering the ground shape on my units. I used colors from the unlit range, but I doubt that has effect for this kind of sprites? Also ,does Frames affect both Shape and GroundShape simultaneously?

[Speederovsky]

Seems like shape being covered by the shadows depends on DrawAboveTechno.
What's up with this though? Why is the shape drawn off-center for jumpjet infantry?

[Metadorius]

I wonder how that dotted pattern is achieved too...

[ZivDero]

I wonder how that dotted pattern is achieved too...

There is a line draw functiont hat draws a line with a bool[] pattern.

[NetsuNegi]

I wonder how that dotted pattern is achieved too...

done

[Speederovsky]

Centering for Inf seems fixed.

[Metadorius]

Suggested change

	
	

[Metadorius]

suggest to add GroundLine.AlwaysDraw too and maybe make the pattern customisable

[Metadorius]

the fact that it's Damageable is not indicated in docs, maybe Shape and GroundShape should also be Damageable then too?

[NetsuNegi]

no, I did

[Metadorius]

oh I missed that, pardon
what about the shapes being Damageable?

[NetsuNegi]

no need that just control by frame index

[Metadorius]

how did Grounded work before by the way? maybe some migration could be added?

[Metadorius]

@ZivDero could you consult @NetsuNegi regarding the pattern?

[NetsuNegi]

@ZivDero could you consult @NetsuNegi regarding the pattern?

what ?

[Metadorius]

what ?

1. he had some suggestion regarding usage of dashed line pattern
2. it could be good to have it specified in INI, maybe as something like GroundLine.DashedPattern=true,false,...

[NetsuNegi]

what ?

1. he had some suggestion regarding usage of dashed line pattern
2. it could be good to have it specified in INI, maybe as something like GroundLine.DashedPattern=true,false,...

I dont know what was that

[ZivDero]

what ?

1. he had some suggestion regarding usage of dashed line pattern
2. it could be good to have it specified in INI, maybe as something like GroundLine.DashedPattern=true,false,...

I dont know what was that

The dashed line pattern is a static bool[16] that determines which pixels are drawn. There is no need to reference the one that exists in the game.
At a minimum, you can just define your own static bool[16]. Or do what Kerbiter suggested and istead of making it static, read the bool[16] from the ini so the user can customize the pattern (though I think that may potentially be a bit too much customization?)

[Metadorius]

what ?

1. he had some suggestion regarding usage of dashed line pattern
2. it could be good to have it specified in INI, maybe as something like GroundLine.DashedPattern=true,false,...

I dont know what was that

The dashed line pattern is a static bool[16] that determines which pixels are drawn. There is no need to reference the one that exists in the game. At a minimum, you can just define your own static bool[16]. Or do what Kerbiter suggested and istead of making it static, read the bool[16] from the ini so the user can customize the pattern (though I think that may potentially be a bit too much customization?)

If it can be done -- why not?

Also, is it required to be bool[16] specifically?