Save size, position for Main Window, Output Window on program start #630
Conversation
| @@ -88,6 +89,7 @@ class FileWindowLoggerWindow : public QMainWindow{ | |||
| FileWindowLogger& m_logger; | |||
| QMenuBar* m_menubar; | |||
| QTextEdit* m_text; | |||
| bool m_pending_resize = false; | |||
There was a problem hiding this comment.
Where does this get used? I see it set, but it's never read.
There was a problem hiding this comment.
To be honest, I just copy pasted it without understanding its purpose.
I now understand what it's for and I don't need it at this time.
…. Fix bug with re-opening the Output window.
|
After pushing the initial PR, I realized there were a few other features I wanted to implement. |
| uint32_t const screen_height = (uint32_t)screen_geometry.height(); | ||
| uint32_t initial_x_pos_main = GlobalSettings::instance().WINDOW_SIZE->INITIAL_X_POS; | ||
| uint32_t initial_y_pos_main = GlobalSettings::instance().WINDOW_SIZE->INITIAL_Y_POS; | ||
| uint32_t move_x_main = std::min(initial_x_pos_main, screen_width-100); |
There was a problem hiding this comment.
What happens if this goes negative? screen_width-100 < 0
There was a problem hiding this comment.
I assumed that PA would be run on screens bigger than 100 pixels. But fair enough, I'll change it to screen_width*0.97.
|
This PR should be done now. |
jw098
changed the title
No description provided.