Skip to content

ffi: expose PyDateTime_*_GET_TZINFO on PyPy #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

exg
Copy link
Contributor

@exg exg commented Apr 19, 2025

They are available in PyPy3.10 and PyPy3.11.

Thank you for contributing to PyO3!

By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.

Please consider adding the following to your pull request:

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
    • or start the PR title with docs: if this is a docs-only change to skip the check
    • or start the PR title with ci: if this is a ci-only change to skip the check
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request, thus make sure you have checked the Contributing.md guidelines. To run most of its tests
locally, you can run nox. See nox --list-sessions
for a list of supported actions.

@bschoenmaeckers
Copy link
Member

Can we use this to simplify PyTzInfoAccess?

@davidhewitt davidhewitt added this pull request to the merge queue Apr 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 21, 2025
@bschoenmaeckers
Copy link
Member

Seems like PyTzInfoAccess cannot be simplified on 3.9 because the ffi function is for 3.10 onwards .

Copy link
Member

@bschoenmaeckers bschoenmaeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can conditional compile on the Py_3_10 flag in PyTzInfoAccess.

They are available in PyPy3.10 and PyPy3.11.
@bschoenmaeckers bschoenmaeckers added this pull request to the merge queue Apr 22, 2025
Merged via the queue into PyO3:main with commit 0062d5e Apr 22, 2025
43 of 45 checks passed
@exg exg deleted the pypy branch April 22, 2025 13:11
newcomertv pushed a commit to newcomertv/pyo3 that referenced this pull request Apr 28, 2025
They are available in PyPy3.10 and PyPy3.11.
@exg
Copy link
Contributor Author

exg commented May 1, 2025

@davidhewitt do you plan to release a new version with this change anytime soon?

@davidhewitt
Copy link
Member

#5107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants