-
Notifications
You must be signed in to change notification settings - Fork 834
ffi: expose PyDateTime_*_GET_TZINFO on PyPy #5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we use this to simplify |
1febc5f
to
788de0a
Compare
Seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can conditional compile on the Py_3_10
flag in PyTzInfoAccess
.
They are available in PyPy3.10 and PyPy3.11.
They are available in PyPy3.10 and PyPy3.11.
@davidhewitt do you plan to release a new version with this change anytime soon? |
They are available in PyPy3.10 and PyPy3.11.
Thank you for contributing to PyO3!
By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.
Please consider adding the following to your pull request:
docs:
if this is a docs-only change to skip the checkci:
if this is a ci-only change to skip the checkPyO3's CI pipeline will check your pull request, thus make sure you have checked the
Contributing.md
guidelines. To run most of its testslocally, you can run
nox
. Seenox --list-sessions
for a list of supported actions.