-
-
Notifications
You must be signed in to change notification settings - Fork 478
feat(commands): add support for typing.Literal[...] as command choices #2782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lumouille <[email protected]>
Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lumouille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lumouille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the concept, I don't have time to read the code
does this need something else before being merged ? |
Summary
permit the usage of choice like so :
instead of needed to do
or
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.