Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info to appFinished event for extension #1036

Merged
merged 1 commit into from
Jun 27, 2024
Merged

add more info to appFinished event for extension #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/agents/task_completer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,16 @@ async def run(self) -> AgentResponse:

if current_task_index1 == len(tasks):
if source == "app":
await self.ui.send_app_finished()
await self.ui.send_app_finished(
app_id=str(self.state_manager.project.id),
app_name=self.state_manager.project.name,
folder_name=self.state_manager.project.folder_name,
)
elif source == "feature":
await self.ui.send_feature_finished()
await self.ui.send_feature_finished(
app_id=str(self.state_manager.project.id),
app_name=self.state_manager.project.name,
folder_name=self.state_manager.project.folder_name,
)

return AgentResponse.done(self)
22 changes: 20 additions & 2 deletions core/ui/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,33 @@ async def send_key_expired(self, message: Optional[str] = None):
"""
raise NotImplementedError()

async def send_app_finished(self):
async def send_app_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
"""
Send the app finished message.

:param app_id: App ID.
:param app_name: App name.
:param folder_name: Folder name.
"""
raise NotImplementedError()

async def send_feature_finished(self):
async def send_feature_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
"""
Send the feature finished message.

:param app_id: App ID.
:param app_name: App name.
:param folder_name: Folder name.
"""
raise NotImplementedError()

Expand Down
16 changes: 13 additions & 3 deletions core/ui/console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,24 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
else:
print(message)

async def send_key_expired(self, message: Optional[str]):
async def send_key_expired(self, message: Optional[str] = None):
if message:
await self.send_message(message)

async def send_app_finished(self):
async def send_app_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
pass

async def send_feature_finished(self):
async def send_feature_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
pass

async def ask_question(
Expand Down
32 changes: 28 additions & 4 deletions core/ui/ipc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,35 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
async def send_key_expired(self, message: Optional[str] = None):
await self._send(MessageType.KEY_EXPIRED)

async def send_app_finished(self):
await self._send(MessageType.APP_FINISHED)
async def send_app_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
await self._send(
MessageType.APP_FINISHED,
content={
"app_id": app_id,
"app_name": app_name,
"folder_name": folder_name,
},
)

async def send_feature_finished(self):
await self._send(MessageType.FEATURE_FINISHED)
async def send_feature_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
await self._send(
MessageType.FEATURE_FINISHED,
content={
"app_id": app_id,
"app_name": app_name,
"folder_name": folder_name,
},
)

async def ask_question(
self,
Expand Down
16 changes: 13 additions & 3 deletions core/ui/virtual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,23 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
else:
print(message)

async def send_key_expired(self, message: Optional[str]):
async def send_key_expired(self, message: Optional[str] = None):
pass

async def send_app_finished(self):
async def send_app_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
pass

async def send_feature_finished(self):
async def send_feature_finished(
self,
app_id: Optional[str] = None,
app_name: Optional[str] = None,
folder_name: Optional[str] = None,
):
pass

async def ask_question(
Expand Down
Loading