Fix sending changes back to rework if nothing got applied. #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senko
commented
Feb 22, 2024
| # If everything can be safely ignoring, it's probably because the files already implement the changes | ||
| # from previous tasks (which can happen often). Insisting on a change here is likely to cause problems. | ||
| return old_content, None | ||
| if hunks_to_rework: |
There was a problem hiding this comment.
We're not always sending the review_log because it is always non-empty (because it includes review_notes). If we applied nothing and asked to rework, we need the log, otherwise if we applied nothing and ignored everything (asked nothing for rework), we don't want for the code monkey to rework it.
| @@ -11,6 +11,6 @@ the full contents of the updated file, without skipping over any content | |||
| ------------------------end_of_format--------------------------- | |||
|
|
|||
| **IMPORTANT**: Your reply MUST NOT omit any code in the new implementation or substitute anything with comments like `// .. rest of the code goes here ..` or `# insert existing code here`, because I will overwrite the existing file with the content you provide. Output ONLY the content for this file, without additional explanation, suggestions or notes. Your output MUST start with ``` and MUST end with ``` and include only the complete file contents. | |||
| **IMPORTANT**: If the user must configure something manually, mark the line that needs user configuration with `INPUT_REQUIRED {input_description}` comment, where `input_description` is a description of what needs to be added here by the user. Use appropriate syntax for comments in the file you're saving (for example `// INPUT_REQUIRED {input_description}` in JavaScript). If the file type doesn't support comments (eg JSON), don't add any. | |||
| **IMPORTANT**: Avoid hardcoding configuration values (eg. port, database url or server secret string) in code. Instead, use appropriate settings file (for example `.env`) for all user-configurable settings. Mark line(s) that need user configuration with `INPUT_REQUIRED {input_description}` comment, where `input_description` is a description of what needs to be added in that line by the user. Use appropriate syntax for comments in the file you're saving (for example `# INPUT_REQUIRED {input_description}` in `.env`). If the file type doesn't support comments (eg JSON), don't add any. | |||
There was a problem hiding this comment.
It is the hope of this author that this heartfelt plea will induce the LLM to be more considerate with respect to peppering INPUT_REQUIRED throughout the code and the resulting mental anguish that causes to the user.
Also, try to prevent LLMs use of INPUT_REQUIRED for code.
senko
force-pushed
the
implement-changes-and-reviewer-fixes
branch
from
0f19ce4 to
016349f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, try to tone down LLMs se of INPUT_REQUIRED.