enables make vm-create in gentoo linux #1
Conversation
romulocollopy
force-pushed
the
gentoo-vm-install
branch
from
60e7c66 to
4ebc4fc
Compare
| if is_gentoo; then | ||
| mkdir -p /var/lib/libvirt/images | ||
| fi |
There was a problem hiding this comment.
This line is not required by Gentoo only and also could be improved to reuse the variable where the image path is stored. I prefer changing it to:
| if is_gentoo; then | |
| mkdir -p /var/lib/libvirt/images | |
| fi | |
| mkdir -p $(dirname "$DEBIAN_QCOW2") |
| fi | ||
| } | ||
|
|
||
| function qemu_connect() { |
There was a problem hiding this comment.
This function name does not describe what it does (all virsh commands connect to qemu in a way or another). I suggest config_virsh_network.
| function qemu_connect() { | |
| function config_virsh_network() { |
| wget -c -t 0 -O "$DEBIAN_QCOW2" "$DEBIAN_QCOW2_URL" | ||
| install_libs | ||
| config_permissions | ||
| qemu_connect |
There was a problem hiding this comment.
| qemu_connect | |
| config_virsh_network |
|
|
||
| if is_gentoo; then | ||
| mkdir /var/lib/libvirt/shared/debian12-pydokku | ||
| mkdir /var/lib/libvirt/boot | ||
| fi | ||
|
|
There was a problem hiding this comment.
I didn't understand why those lines are needed, since there's mkdir -p "$SHARED_FOLDER" inside create_shared_folder already (which does the same as the first line inside the if) and /var/lib/libvirt/boot is not used at all.
I suggest you trying to completely remove this if, completely remove the VM (virt-manager could help) and running the make vm-create without them to check if this is really required.
| if is_gentoo; then | |
| mkdir /var/lib/libvirt/shared/debian12-pydokku | |
| mkdir /var/lib/libvirt/boot | |
| fi |
No description provided.