-
Notifications
You must be signed in to change notification settings - Fork 99
Write public guide for using BitArray directly #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamFerracin
wants to merge
16
commits into
Qiskit:main
Choose a base branch
from
SamFerracin:sampler-out
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
46cf5ed
first draft
SamFerracin 55dc8ec
typo
SamFerracin 9a8ddf6
lint
SamFerracin bdb0385
fix
SamFerracin 6a2c4a3
lint
SamFerracin a740e11
conflicts
SamFerracin 834b37d
optionally, convert away from the native BitArray format to a diction…
SamFerracin de89695
removed getcounts
SamFerracin cd627fd
rewording
SamFerracin f1c9c71
keyword --> keu
SamFerracin a2645cb
more progress
SamFerracin 0d26c24
minor copyediting tweaks
abbycross 6a99212
fineshed up narrative
SamFerracin 2f53e3e
Merge branch 'sampler-out' of https://github.com/SamFerracin/document…
SamFerracin 326cf34
lint
SamFerracin 66f9151
one can use --> use
SamFerracin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a nice simplification/clarification in plainer english. I also think that one of the first things that should be said after BitArray is mentioned is that it is just a container for ordered shot data. Then, in the next paragraph, it can be emphasized, somehow, that get_counts is a convenience to change formats.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a2645cb and 6a99212