Skip to content

Add SKQD tutorial #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add SKQD tutorial #3002

wants to merge 8 commits into from

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Apr 16, 2025

Fixes #3003

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to add this to notebook-testing.toml. ./check should complain

Copy link
Collaborator

@jenglick jenglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinsung Thanks! I left some comments via the ReviewNB app here.

@nathanearnestnoble
Copy link
Collaborator

@miamico

@nathanearnestnoble
Copy link
Collaborator

Thanks Kevin! I think it is fairly solid, some minor feedback:

  • I think it would be useful to reference our Krylov tutorial as well, in case people want to gain a deeper understand of the specifics around it
  • @miamico made a good point that I wanted to raise: As you are specifically using the impurity anderson hamiltonian from the paper, you need to introduce an additional step of changing from position basis to momentum basis. I think there could be a benefit to have two component to the tutorial: a simpler hamitlonian that does not require this mapping because it is already sparse, and then a second "more advanced" part II highlight the specific step of basis change to overcome the issue of having a non-sparse matrix and is brief on other elements of the workflow already discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

SKQD tutorial
4 participants