-
Notifications
You must be signed in to change notification settings - Fork 99
first-pass through tutorials for copyediting #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -1265,7 +1264,7 @@ | |||
"source": [ | |||
"Finally, let's draw a graph based on the CVaR result.\n", | |||
"We split the graph nodes into two sets based on the CVaR result.\n", | |||
"The nodes in the first set are colored in grey, and the nodes in the second set are colored in purple.\n", | |||
"The nodes in the first set are colored in gray, and the nodes in the second set are colored in purple.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility we need a second way to distinguish between the two sets (not just the two colors). @beckykd suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on what the application is capable of. Can they be pattern filled? Can one be just an outline and one filled?
One or more of the following people are relevant to this code: |
@@ -281,7 +281,7 @@ | |||
"job = ibm_cf.run(\n", | |||
" pubs=[(circuit, observable)],\n", | |||
" instance=instance,\n", | |||
" backend_name=backend_name, # E.g. \"ibm_kyiv\"\n", | |||
" backend_name=backend_name, # E.g. \"ibm_fez\"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. is one of those Latin abbreviations that we aren't supposed to use. Maybe you want to address these in your follow up PR?
@@ -1265,7 +1264,7 @@ | |||
"source": [ | |||
"Finally, let's draw a graph based on the CVaR result.\n", | |||
"We split the graph nodes into two sets based on the CVaR result.\n", | |||
"The nodes in the first set are colored in grey, and the nodes in the second set are colored in purple.\n", | |||
"The nodes in the first set are colored in gray, and the nodes in the second set are colored in purple.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on what the application is capable of. Can they be pattern filled? Can one be just an outline and one filled?
@@ -7,7 +7,7 @@ | |||
"source": [ | |||
"{/* cspell:ignore setminus coloneqq rbrack // latex that isn't being ignored for some reason */}\n", | |||
"\n", | |||
"# Solving Maxcut with Reduced Qubit Requirements Using Pauli Correlation Encoding\n", | |||
"# Pauli Correlation Encoding to reduce Maxcut requirements\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "correlation encoding" need to be upper case? and "maxcut"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correlation encoding can be lower case, but I'm not sure about Maxcut
@@ -847,7 +847,7 @@ | |||
"version": "3" | |||
}, | |||
"platform": "cloud", | |||
"title": "Solve higher-order binary optimization problems with Q-CTRL's Optimization Solver" | |||
"title": "Higher-order binary optimization with Q-CTRL's Optimization Solver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q-CTRL is trademarked, so it shouldn't be made possessive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Includes work that will close #2992
In addition to a general copyedit: