-
Notifications
You must be signed in to change notification settings - Fork 111
[UnitaryHack 2025] doc update #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hey @AprilSweettooth, can you please link to which GitHub issue this is addressing? That will help to assign the correct reviewers. |
Hey @Eric-Arellano , it is for this one Add details of prob_meas0_prep1, prob_meas1_prep0, readout_length #3018 |
Hi @AprilSweettooth! Before I can run CI and go through the review, would you mind signing the contributor agreement? |
Hey @kaelynj I have signed it, thanks. Hey @Eric-Arellano, could you point me to the places where things went wrong in the notebook? Because it runs smoothly on my local laptop. Thanks! |
Adding the Quantum Diagonalization Algorithms course notebooks and images. --------- Co-authored-by: ABBY CROSS <[email protected]> Co-authored-by: Frank Harkins <[email protected]>
Hi Could someone help me review this PR, I think the notebook works fine locally but it requires the account id when doing the checks. Not sure how to get around this. Thanks! @Eric-Arellano @kaelynj |
Hi @AprilSweettooth, with the way our CI is configured the notebook testing won't run if the PR was opened with a fork. I can verify it myself and I'll go ahead and review this now. Thanks for being patient! |
Thanks @kaelynj ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content here looks great. I think the only thing you'll need to do now after applying these suggested changes would be to make sure the linter works correctly. You should be able to fix the issues with it using the ./check
and ./fix
scripts in the repo.
ImageMagick.tar.gz
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be removed
Co-authored-by: Kaelyn Ferris <[email protected]>
Hey @kaelynj , I've run the check and there seem to be some issues. However, the log is not very clear about how to resolve this issue. Is there a clearer way to fix the errors? |
Ah yeah, the container registry we use to build images is currently down so CI is temporarily not working. I'll run these again once it's back up. |
@AprilSweettooth looks like CI is working correctly again, but the linter is still failing. Try running the |
Hey @kaelynj , fix passed, but when I run check I got ——————————————————————————————————————————————————
(node:18300) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time Do you know how to resolve this? |
Hi @kaelynj, it appears that the error still originates from an account issue. |
The notebook tests failing is expected, but it looks like the lint workflow is still having issues (I tried running |
No description provided.