Skip to content

[UnitaryHack 2025] doc update #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

AprilSweettooth
Copy link

No description provided.

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented May 28, 2025

CLA assistant check
All committers have signed the CLA.

@Eric-Arellano
Copy link
Collaborator

Hey @AprilSweettooth, can you please link to which GitHub issue this is addressing? That will help to assign the correct reviewers.

@AprilSweettooth
Copy link
Author

@kaelynj kaelynj self-requested a review May 28, 2025 19:48
@kaelynj
Copy link
Collaborator

kaelynj commented May 28, 2025

Hi @AprilSweettooth! Before I can run CI and go through the review, would you mind signing the contributor agreement?

@AprilSweettooth
Copy link
Author

Hey @kaelynj I have signed it, thanks.

Hey @Eric-Arellano, could you point me to the places where things went wrong in the notebook? Because it runs smoothly on my local laptop. Thanks!

christopherporter1 and others added 3 commits May 29, 2025 18:24
Adding the Quantum Diagonalization Algorithms course notebooks and
images.

---------

Co-authored-by: ABBY CROSS <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
@AprilSweettooth
Copy link
Author

Hi Could someone help me review this PR, I think the notebook works fine locally but it requires the account id when doing the checks. Not sure how to get around this. Thanks! @Eric-Arellano @kaelynj

@AprilSweettooth AprilSweettooth changed the title unitaryHack doc update [UnitaryHack 2025] doc update May 30, 2025
@kaelynj
Copy link
Collaborator

kaelynj commented Jun 2, 2025

Hey @kaelynj I have signed it, thanks.

Hey @Eric-Arellano, could you point me to the places where things went wrong in the notebook? Because it runs smoothly on my local laptop. Thanks!

Hi Could someone help me review this PR, I think the notebook works fine locally but it requires the account id when doing the checks. Not sure how to get around this. Thanks! @Eric-Arellano @kaelynj

Hi @AprilSweettooth, with the way our CI is configured the notebook testing won't run if the PR was opened with a fork. I can verify it myself and I'll go ahead and review this now. Thanks for being patient!

@AprilSweettooth
Copy link
Author

Thanks @kaelynj !

Copy link
Collaborator

@kaelynj kaelynj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content here looks great. I think the only thing you'll need to do now after applying these suggested changes would be to make sure the linter works correctly. You should be able to fix the issues with it using the ./check and ./fix scripts in the repo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed

@AprilSweettooth
Copy link
Author

Hey @kaelynj , I've run the check and there seem to be some issues. However, the log is not very clear about how to resolve this issue. Is there a clearer way to fix the errors?

@kaelynj
Copy link
Collaborator

kaelynj commented Jun 2, 2025

Hey @kaelynj , I've run the check and there seem to be some issues. However, the log is not very clear about how to resolve this issue. Is there a clearer way to fix the errors?

Ah yeah, the container registry we use to build images is currently down so CI is temporarily not working. I'll run these again once it's back up.

@kaelynj
Copy link
Collaborator

kaelynj commented Jun 4, 2025

@AprilSweettooth looks like CI is working correctly again, but the linter is still failing. Try running the ./fix script and see if that helps.

@AprilSweettooth
Copy link
Author

Hey @kaelynj , fix passed, but when I run check I got

——————————————————————————————————————————————————

[email protected] check:qiskit-bot
tsx scripts/js/commands/checkQiskitBotFiles.ts

(node:18300) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use node --trace-warnings ... to show where the warning was created)
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'globby' imported from Downloads/documentation/scripts/js/commands/checkQiskitBotFiles.ts
at __node_internal_captureLargerStackTrace (node:internal/errors:464:5)
at new NodeError (node:internal/errors:371:5)
at packageResolve (node:internal/modules/esm/resolve:884:9)
at moduleResolve (node:internal/modules/esm/resolve:929:18)
at defaultResolve (node:internal/modules/esm/resolve:1044:11)
at resolveBase (file:///usr/local/lib/node_modules/tsx/dist/esm/index.mjs:2:3212)
at resolveDirectory (file:///usr/local/lib/node_modules/tsx/dist/esm/index.mjs:2:3584)
at resolveTsPaths (file:///usr/local/lib/node_modules/tsx/dist/esm/index.mjs:2:4073)
at resolve (file:///usr/local/lib/node_modules/tsx/dist/esm/index.mjs:2:4447)
at ESMLoader.resolve (node:internal/modules/esm/loader:422:30)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:222:40)
at ModuleWrap. (node:internal/modules/esm/module_job:76:40)
at link (node:internal/modules/esm/module_job:75:36)
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
code: 'ERR_MODULE_NOT_FOUND'
}

Do you know how to resolve this?

@AprilSweettooth
Copy link
Author

Hi @kaelynj, it appears that the error still originates from an account issue.

@kaelynj
Copy link
Collaborator

kaelynj commented Jun 4, 2025

Hi @kaelynj, it appears that the error still originates from an account issue.

The notebook tests failing is expected, but it looks like the lint workflow is still having issues (I tried running ./fix again locally and it passed the ./check script after so you may need to commit the changes it makes). And unfortunately a separate submission working on the same issue was able to get approval first. If you'd like though I'm still happy to help walk you through the process of finalizing this PR. I just won't be able to merge it. Regardless, we really appreciate your help and good luck with the rest of the Unitary Hack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants