Skip to content

Commit 6c878c3

Browse files
committed
Merge remote-tracking branch 'remotes/origin/gh-pages' into develop
Conflicts: quickblox.min.js
2 parents 96a7be7 + d552887 commit 6c878c3

File tree

6 files changed

+31
-14
lines changed

6 files changed

+31
-14
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ For correct work of JS SDK you must include the library in your html before `qu
2020

2121
```html
2222
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
23-
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.2/quickblox.min.js"></script>
23+
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.4/quickblox.min.js"></script>
2424
```
2525

2626
## Bower and RequireJS

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.2",
4+
"version": "2.3.4",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "quickblox.js",
77
"license": "Apache 2.0",

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.2",
4+
"version": "2.3.4",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "src/qbMain.js",
77
"license": "(Apache-2.0)",

spec/QB-ChatSpec.js

+14-9
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,13 @@ describe('Chat API', function() {
6868
body: body,
6969
extension: msgExtension,
7070
markable: 1
71-
};
71+
};
7272

7373
function onMsgCallback(userId, receivedMessage) {
7474
expect(userId).toEqual(QBUser1.id);
7575

7676
expect(receivedMessage).toBeDefined();
77+
expect(receivedMessage.id).toEqual(msg.id);
7778
expect(receivedMessage.type).toEqual(msg.type);
7879
expect(receivedMessage.body).toEqual(body);
7980
expect(receivedMessage.extension).toEqual(msgExtension);
@@ -83,27 +84,31 @@ describe('Chat API', function() {
8384
}
8485

8586
QB.chat.onMessageListener = onMsgCallback;
86-
QB.chat.send(QBUser1.id, msg);
87+
msg.id = QB.chat.send(QBUser1.id, msg);
8788
}, MESSAGING_TIMEOUT);
8889

8990
it('can send and receive system message', function(done) {
90-
var extension = {
91-
name: 'Walle',
92-
action: 'Found love'
93-
};
91+
var msg = {
92+
body: 'Notification',
93+
extension:{
94+
name: 'Walle',
95+
action: 'Found love'
96+
}
97+
};
9498

9599
function onSystemMessageListenerCb(receivedMessage) {
96100
expect(receivedMessage).toBeDefined();
97101

98102
expect(receivedMessage.userId).toEqual(QBUser1.id);
99-
expect(receivedMessage.extension).toEqual(extension);
103+
expect(receivedMessage.id).toEqual(msg.id);
104+
expect(receivedMessage.body).toEqual(msg.body);
105+
expect(receivedMessage.extension).toEqual(msg.extension);
100106

101107
done();
102108
}
103109

104110
QB.chat.onSystemMessageListener = onSystemMessageListenerCb;
105-
106-
QB.chat.sendSystemMessage(QBUser1.id, {'extension': extension});
111+
msg.id = QB.chat.sendSystemMessage(QBUser1.id, msg);
107112
}, MESSAGING_TIMEOUT);
108113

109114
it('can send and receive \'delivered\' status', function(done) {

src/modules/qbChat.js

+13-1
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ function ChatProxy(service, webrtcModule, conn) {
313313
extraParams = chatUtils.getElement(stanza, 'extraParams'),
314314
delay = chatUtils.getElement(stanza, 'delay'),
315315
moduleIdentifier = chatUtils.getElementText(extraParams, 'moduleIdentifier'),
316+
bodyContent = chatUtils.getElementText(stanza, 'body'),
316317
message;
317318

318319
if (moduleIdentifier === 'SystemNotifications' && typeof self.onSystemMessageListener === 'function') {
@@ -321,6 +322,7 @@ function ChatProxy(service, webrtcModule, conn) {
321322
message = {
322323
id: messageId,
323324
userId: self.helpers.getIdFromNode(from),
325+
body: bodyContent,
324326
extension: extraParamsParsed.extension
325327
};
326328

@@ -608,6 +610,8 @@ ChatProxy.prototype = {
608610

609611
nClient.send(stanza);
610612
}
613+
614+
return paramsCreateMsg.id;
611615
},
612616
sendSystemMessage: function(jid_or_user_id, message) {
613617
var self = this,
@@ -620,14 +624,20 @@ ChatProxy.prototype = {
620624

621625
var stanza = chatUtils.createStanza(builder, paramsCreateMsg);
622626

627+
if (message.body) {
628+
stanza.c('body', {
629+
xmlns: chatUtils.MARKERS.CLIENT,
630+
}).t(message.body).up();
631+
}
632+
623633
if(Utils.getEnv().browser) {
624634
// custom parameters
625635
if (message.extension) {
626636
stanza.c('extraParams', {
627637
xmlns: chatUtils.MARKERS.CLIENT
628638
}).c('moduleIdentifier').t('SystemNotifications').up();
629639

630-
stanza = chatUtils.filledExtraParams(stanza, message.extension);
640+
stanza = chatUtils.filledExtraParams(stanza, message.extension);
631641
}
632642

633643
connection.send(stanza);
@@ -644,6 +654,8 @@ ChatProxy.prototype = {
644654

645655
nClient.send(stanza);
646656
}
657+
658+
return paramsCreateMsg.id;
647659
},
648660
sendIsTypingStatus: function(jid_or_user_id) {
649661
var self = this,

src/qbConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*/
1313

1414
var config = {
15-
version: '2.3.2',
15+
version: '2.3.4',
1616
creds: {
1717
appId: '',
1818
authKey: '',

0 commit comments

Comments
 (0)