Skip to content

Commit ab12c0b

Browse files
authored
Merge pull request #165 from QuickBlox/gh-pages.sendSystemMessageWithBody
Added body tag for system message (type 'headline')
2 parents 309e4d8 + a64508c commit ab12c0b

File tree

7 files changed

+24
-12
lines changed

7 files changed

+24
-12
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ For correct work of JS SDK you must include the library in your html before `qu
2020

2121
```html
2222
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
23-
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.2/quickblox.min.js"></script>
23+
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.3/quickblox.min.js"></script>
2424
```
2525

2626
## Bower and RequireJS

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.2",
4+
"version": "2.3.3",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "quickblox.js",
77
"license": "Apache 2.0",

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.2",
4+
"version": "2.3.3",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "src/qbMain.js",
77
"license" : "(Apache-2.0)",

quickblox.min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/QB-ChatSpec.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -87,23 +87,27 @@ describe('Chat API', function() {
8787
}, MESSAGING_TIMEOUT);
8888

8989
it('can send and receive system message', function(done) {
90-
var extension = {
91-
name: 'Walle',
92-
action: 'Found love'
90+
var msg = {
91+
body: 'Notification',
92+
extension:{
93+
name: 'Walle',
94+
action: 'Found love'
95+
}
9396
};
9497

9598
function onSystemMessageListenerCb(receivedMessage) {
9699
expect(receivedMessage).toBeDefined();
97100

98101
expect(receivedMessage.userId).toEqual(QBUser1.id);
99-
expect(receivedMessage.extension).toEqual(extension);
102+
expect(receivedMessage.body).toEqual(msg.body);
103+
expect(receivedMessage.extension).toEqual(msg.extension);
100104

101105
done();
102106
}
103107

104108
QB.chat.onSystemMessageListener = onSystemMessageListenerCb;
105109

106-
QB.chat.sendSystemMessage(QBUser1.id, {'extension': extension});
110+
QB.chat.sendSystemMessage(QBUser1.id, msg);
107111
}, MESSAGING_TIMEOUT);
108112

109113
it('can send and receive \'delivered\' status', function(done) {

src/modules/qbChat.js

+8
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ function ChatProxy(service, webrtcModule, conn) {
312312
extraParams = chatUtils.getElement(stanza, 'extraParams'),
313313
delay = chatUtils.getElement(stanza, 'delay'),
314314
moduleIdentifier = chatUtils.getElementText(extraParams, 'moduleIdentifier'),
315+
bodyContent = chatUtils.getElementText(stanza, 'body'),
315316
message;
316317

317318
if (moduleIdentifier === 'SystemNotifications' && typeof self.onSystemMessageListener === 'function') {
@@ -320,6 +321,7 @@ function ChatProxy(service, webrtcModule, conn) {
320321
message = {
321322
id: messageId,
322323
userId: self.helpers.getIdFromNode(from),
324+
body: bodyContent,
323325
extension: extraParamsParsed.extension
324326
};
325327

@@ -619,6 +621,12 @@ ChatProxy.prototype = {
619621

620622
var stanza = chatUtils.createStanza(builder, paramsCreateMsg);
621623

624+
if (message.body) {
625+
stanza.c('body', {
626+
xmlns: chatUtils.MARKERS.CLIENT,
627+
}).t(message.body).up();
628+
}
629+
622630
if(Utils.getEnv().browser) {
623631
// custom parameters
624632
if (message.extension) {

src/qbConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
var config = {
13-
version: '2.3.2',
13+
version: '2.3.3',
1414
creds: {
1515
appId: '',
1616
authKey: '',

0 commit comments

Comments
 (0)