Skip to content

fix(core): When an error occurs during SSR due to using the browser APIs, show an explanation #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: build/v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e13b384
Merge pull request #9 from QwikDev/build/v2
JerryWu1234 Apr 11, 2025
94e47d7
fix(repl): improve deepUpdate logic for array item matching
JerryWu1234 Apr 11, 2025
69dd8fb
fix it
JerryWu1234 Apr 22, 2025
484cb85
fix(core): prevent server-side usage of browser APIs
JerryWu1234 Apr 30, 2025
e6bf18e
add change
JerryWu1234 Apr 30, 2025
ffa2f30
fix(qrl): improve error message for browser API usage in SSR
JerryWu1234 May 8, 2025
2c23bd1
docs(changeset): update changeset from major to patch
JerryWu1234 May 9, 2025
90ccf26
feat(core): improve error message for SSR browser API usage
JerryWu1234 May 12, 2025
765ce4a
Merge branch 'QwikDev:build/v2' into build/v2
JerryWu1234 May 12, 2025
ff28ef1
solve confilict
JerryWu1234 May 12, 2025
e57626f
test(use-task): update test case for error handling in useTask$
JerryWu1234 May 14, 2025
01b2f8d
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 14, 2025
fb2ed8a
test(use-task): update error handling test to use ErrorProvider
JerryWu1234 May 14, 2025
3a240e2
Merge branch 'v2-7514-improvement-usetask' of https://github.com/Jerr…
JerryWu1234 May 14, 2025
67e517d
feat(eslint-plugin-qwik): add scope-use-task rule to enforce server g…
JerryWu1234 May 14, 2025
46d7a67
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 14, 2025
25d8119
test(scope-use-task): update test cases for unsafe API usage
JerryWu1234 May 14, 2025
68b2d34
Merge branch 'v2-7514-improvement-usetask' of https://github.com/Jerr…
JerryWu1234 May 14, 2025
764d3b2
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 16, 2025
8764565
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 21, 2025
9a06edf
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 26, 2025
3289e51
Merge branch 'build/v2' into v2-7514-improvement-usetask
JerryWu1234 May 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-rules-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@qwik.dev/core': patch
---

FEAT: When an error occurs during SSR due to using the browser APIs, show an explanation.
4 changes: 4 additions & 0 deletions packages/eslint-plugin-qwik/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { useMethodUsage } from './src/useMethodUsage';
import { validLexicalScope } from './src/validLexicalScope';
import { serializerSignalUsage } from './src/serializerSignalUsage';
import pkg from './package.json';
import { scopeUseTask } from './src/scope-use-task';

type Rules = NonNullable<TSESLint.FlatConfig.Plugin['rules']>;

Expand All @@ -28,6 +29,7 @@ const rules = {
'jsx-a': jsxAtag,
'no-use-visible-task': noUseVisibleTask,
'serializer-signal-usage': serializerSignalUsage,
'scope-use-task': scopeUseTask,
} satisfies Rules;

const recommendedRulesLevels = {
Expand All @@ -43,6 +45,7 @@ const recommendedRulesLevels = {
'qwik/jsx-a': 'warn',
'qwik/no-use-visible-task': 'warn',
'qwik/serializer-signal-usage': 'error',
'qwik/scope-use-task': 'error',
} satisfies TSESLint.FlatConfig.Rules;

const strictRulesLevels = {
Expand All @@ -58,6 +61,7 @@ const strictRulesLevels = {
'qwik/jsx-a': 'error',
'qwik/no-use-visible-task': 'warn',
'qwik/serializer-signal-usage': 'error',
'qwik/scope-use-task': 'error',
} satisfies TSESLint.FlatConfig.Rules;

const configs = {
Expand Down
Loading
Loading