Skip to content

fix(vite): the @qwik-handlers aren't properly handled in dev mode for library projects #7608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: build/v2
Choose a base branch
from
Open

fix(vite): the @qwik-handlers aren't properly handled in dev mode for library projects #7608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0180d95
fix(vite): simplify plugin return logic by removing unnecessary condi…
JerryWu1234 May 17, 2025
97c3917
fix(core): handle @qwik-handlers properly in dev mode for library pro…
JerryWu1234 May 19, 2025
96ed68f
chore: update changeset version from major to patch
JerryWu1234 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-points-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@qwik.dev/core': patch
---

fix: the @qwik-handlers aren't properly handled in dev mode for library projects
9 changes: 1 addition & 8 deletions packages/qwik/src/optimizer/src/plugins/vite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,14 +665,7 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
);
};
// TODO: Removed the "__qwikCityNew" condition in V3
const isNEW =
(globalThis as any).__qwikRouterNew === true ||
(globalThis as any).__qwikCityNew === true;
if (isNEW) {
return plugin;
} else {
return plugin();
}
return plugin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you look in the commit history to see why this was added?

Are you sure that the function gets executed? Can you add a console.log() inside it to check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin this function ? @wmertens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it directly returns a function, that function will be invoked by Vite at the very end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryWu1234 if the comment says "remove in V3" it means that we deprecate it in V2 and then in V3 we'll remove this functionality as a breaking change.

But for now, IIRC this was added to prevent backwards compatability issues, are you saying this has no effect?

can we just check for "library mode" instead and return the plugin in that mode specifically?

}
},

Expand Down