Skip to content

fix: serialize less vnode data #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: build/v2
Choose a base branch
from

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented May 23, 2025

Improve vNode data serialization, simplify the SsrNode class, remove unnecessary vnode preparation logic

@Varixo Varixo self-assigned this May 23, 2025
@Varixo Varixo requested a review from a team as a code owner May 23, 2025 18:56
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: c1baa6c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development May 23, 2025
@Varixo Varixo marked this pull request as draft May 23, 2025 18:56
@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from 536cf58 to c474a8b Compare May 23, 2025 19:03
@Varixo Varixo linked an issue May 23, 2025 that may be closed by this pull request
Copy link

pkg-pr-new bot commented May 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7636
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7636
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7636
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7636

commit: c1baa6c

Copy link
Contributor

github-actions bot commented May 23, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c1baa6c

@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from bea4474 to a417ba7 Compare May 24, 2025 08:52
@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from a417ba7 to c1baa6c Compare May 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

[v2] .map is too eager in creating qrls
1 participant