Skip to content

fix get citation data action issues #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rzhangbq
Copy link

@rzhangbq rzhangbq commented Apr 19, 2025

This provides a fix to Issue #124.

@rzhangbq
Copy link
Author

@RayeRen Could you please help check if this PR could be merged?

@Chord-Chen-30
Copy link

Chord-Chen-30 commented Apr 22, 2025

Hi! Thanks for your fix. I updated the main.py and requirements.txt, but I get errors. Here is the output of "Get citation data"

Traceback (most recent call last):
  File "/home/runner/work/Chord-Chen-30.github.io/Chord-Chen-30.github.io/google_scholar_crawler/main.py", line 9, in <module>
    pg.FreeProxies()  # Use free rotating proxies
    ^^^^^^^^^^^^^^^^
  File "/home/runner/.local/lib/python3.12/site-packages/scholarly/_proxy_generator.py", line 550, in FreeProxies
    proxy = self._proxy_gen(None)  # prime the generator
            ^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.local/lib/python3.12/site-packages/scholarly/_proxy_generator.py", line 518, in _fp_coroutine
    all_proxies = freeproxy.get_proxy_list()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: FreeProxy.get_proxy_list() missing 1 required positional argument: 'repeat'

(I succeeded once before this error, and I use scholarly==1.7.11 as well, which is weird.)

@rzhangbq
Copy link
Author

Hi! Thanks for your feedback. Could you possibly rerun your action? It seems that the free proxy option provided by scholarly does fail to run occationally.

@rzhangbq
Copy link
Author

rzhangbq commented Apr 22, 2025

Even so, mine is running well since I applied the proxy (sometimes rerun is necessary):
image

@Chord-Chen-30
Copy link

Hi! Thanks for your feedback. Could you possibly rerun your action? It seems that the free proxy option provided by scholarly does fail to run occationally.

I re-ran the action and it built successfully. I get it. Thanks

@yaoshanliang
Copy link

How to add this function when the action is running.

@yaoshanliang
Copy link

How to add this function when the action is running.

Author identity unknown
*** Please tell me who you are.
Run
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'runner@fv-az1368-302.(none)')
Error: Process completed with exit code 128.

@jialiangZ
Copy link

Error again, the error is as follows:
image

@rzhangbq
Copy link
Author

rzhangbq commented May 6, 2025

This happens from time to time, but it shouldn’t be a concern if your update frequency is once everyday. However, if you update it only once a week—like I do—you may want to use a try-except block, as shown in my implementation here: google_scholar_crawler/main.py.

@jialiangZ
Copy link

Yes, I have solved the problem. Your answer is very enlightening. Thank you.
google_scholar_crawler/main.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants