Skip to content

Fix typings for mergeAll and concatAll #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lukaselmer
Copy link

// this is how the typings work
const numbers: number[] = Observable.of([1, 2, 3]).mergeAll();
// this would be correct (I think)
const numbers: Observable<number> = Observable.of([1, 2, 3]).mergeAll();

I believe that it is fixed in the next major release #2690

@rxjs-bot
Copy link

Messages
📖

CJS: 3174.4KB, global: 588.9KB (gzipped: 108.6KB), min: 138.0KB (gzipped: 29.1KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.734% when pulling 2dafd0a on lukaselmer:fix-typings into 491970f on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Sep 19, 2017

cc @david-driscoll

@benlesh
Copy link
Member

benlesh commented Mar 30, 2018

I'm unable to verify that there is an issue here, at least in master with pipeable mergeAll. Sorry, @lukaselmer, I'm going to close this for now.

@benlesh benlesh closed this Mar 30, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants