Skip to content

(feat): Add isLatLong API route and function #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cbanlawi
Copy link
Contributor

@cbanlawi cbanlawi commented May 13, 2025

Purpose

  • This PR implements the isLatLong validation endpoint and tests with support for the optional checkDMS flag using a checkbox in the UI.
  • The checkbox allows users to validate DMS (degrees, minutes, seconds) coordinates without modifying the input string (e.g., not requiring "34°3'8.1"N 118°14'37.2"W, true").

Screen Recordings

Functionality:
https://github.com/user-attachments/assets/2c7e26a8-c405-439f-9866-235c406ee0de

Docs:
https://github.com/user-attachments/assets/e18de560-6076-407a-bea6-86b463f6901c

@cbanlawi cbanlawi changed the title (feat): Add latitude-longitude validation endpoint (feat): Add isLatLong API route and function May 13, 2025
@MahdadGhasemian
Copy link
Collaborator

Hi @cbanlawi
Thanks for your contribute!

Please update your PR to only include changes relevant to the functionality you've worked on.
Avoid unrelated changes like converting double quotes (") to single quotes ('), as they make the diff harder to review.

Also, for better contributing and transparency, please include test results. A few screenshots from your local testing would be very helpful.

Thanks again!

@cbanlawi
Copy link
Contributor Author

Hi @cbanlawi

Thanks for your contribute!

Please update your PR to only include changes relevant to the functionality you've worked on.

Avoid unrelated changes like converting double quotes (") to single quotes ('), as they make the diff harder to review.

Also, for better contributing and transparency, please include test results. A few screenshots from your local testing would be very helpful.

Thanks again!

Hi @MahdadGhasemian, my PR is not yet ready for review, but thanks for the feedback!

@cbanlawi cbanlawi marked this pull request as ready for review May 22, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants