gf.c: include const-return methods in --trace-compile
#237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are never compiled by LLVM, but we want to log them since they are inferred / compiled by our own compiler.
kpamnany
force-pushed
the
kp-backport-trace-const-return-methods
branch
from
4533648 to
ba3cfb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is a quick-fix for an issue where methods that are inferred to return a
Constdo not emit compilation traces. Although they are never compiled by LLVM, we want to log them since they are inferred / compiled by Julia. As with #236, it isn't yet clear what the actual upstream fix will look like on 1.12+.Checklist
Requirements for merging:
--trace-compileignores inferred const-return Methods JuliaLang/julia#58482port-to-*labels that don't apply.