-
Notifications
You must be signed in to change notification settings - Fork 8
Ab#78019 changing the context filter to use the filter builder #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Ab#78019 changing the context filter to use the filter builder #2020
Conversation
…the_filter_builder
…der on the context filter screen.
…the_filter_builder
… have an impact on the screen.
…s-settings' calls and removed unused code after implementation.
…the_filter_builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new filter is working as expected in the maps, summary cards and grids.
But the chart filter doesn't load any of the properties of your resource.
I made sure the issue wasn't coming from using an aggregation instead of a layout, but it's working on the other widgets.
I would recommend to find a way to have all the logic to set the dataFilter variable in the same place, so you can reuse the same code in all widgets and avoid specific issues.
…data search for dataFilter.
Adjustments made:
|
…dd missing subscription logic teardowns refactor: remove not necessary properties and imports for ngx-monaco editor refactor: query build filter method in order to avoid the use of promises and have a more clear and readable code fix: remove {{filter.}} value check for the inject dashboard method as with the new filter builder user won't use/need this feature any more
@AntoineRelief I pushed some fixes and refactoring. Now it's working, but maybe we'll have to check deeper in all the filter flow and form logic because im sure that this can be improved. Deleted the |
Description
The purpose of the ticket was to implement the filter-builder in place of the JSON builder within the 'shared-contextual-filters-settings' component. My goal was to maintain the same variable that previously stored the filter as the one responsible for receiving the result from the filter-builder, aiming to minimize the impact of the changes on the system. With that said, I will describe below how the implementation is functioning:
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Screenshots
Checklist:
( * == Mandatory )