Skip to content

AB#93838 - angular update from 15v to 16v #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: beta
Choose a base branch
from

Conversation

AntoineRelief
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Useful links

  • Please insert link to ticket
  • Please insert link to back-end branch if any
  • Please insert any useful link ( documentation you used for example )

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

AntoineRelief and others added 8 commits December 19, 2023 10:41
…ain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
* feat: Update kendo packages  to v14 (#2212)

---------

Co-authored-by: Antoine Hurard <[email protected]>

---------

Co-authored-by: Antoine Hurard <[email protected]>
Co-authored-by: Estela Ferreira <[email protected]>
… add shadowRoot service set inside the shadow root host component in order to keep in one place all related shadow root properties
@AntoineRelief AntoineRelief added keep Do not delete dependencies Pull requests that update a dependency file labels Feb 26, 2024
@AntoineRelief AntoineRelief added the alpha To be released on alpha branch label Apr 29, 2024
@AntoineRelief AntoineRelief changed the base branch from alpha to beta May 16, 2024 15:27
@MwanPygmay
Copy link
Contributor

  • merged beta, resolved conflicts
  • reviewed code
  • ran tests
    Looks good

@AntoineRelief AntoineRelief changed the title Revert 2222 revert 2211 feat/angular update from 15v to 16v AB#93838 - angular update from 15v to 16v May 31, 2024
@AntoineRelief
Copy link
Collaborator Author

@MwanPygmay

if you have some time for this one, there is an issue when you build the project as a web element, and use it in the SUI

the dropdown for the dates is not working when being integrated as web element

@AntoineRelief AntoineRelief marked this pull request as draft June 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha To be released on alpha branch dependencies Pull requests that update a dependency file keep Do not delete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants