Refactor/ab#82357 update angular fix memory leak issues and other fixes #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
* feat: Update kendo packages to v14 (#2212) --------- Co-authored-by: Antoine Hurard <[email protected]> --------- Co-authored-by: Antoine Hurard <[email protected]> Co-authored-by: Estela Ferreira <[email protected]>
…ain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…lain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…lain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…es fix: add missing timeout teardown logic
…es fix: add missing subscription teardown logic part 1
unai-reliefapp
added
keep
…es refactor: inner subscription in order to keep single subscription in all involved observables for back-office app fix: add missing unsubscription logic
…es refactor: inner subscription in order to keep single subscription in all involved observables for front-office and web-components and app and rest of libraries fix: add missing unsubscription logic
unai-reliefapp
force-pushed
the
refactor/AB#82357_update-angular-fix-memory-leak-issues-and-other-fixes
branch
from
363920d to
c24824d
Compare
…es feat: add unsubscription logic for all setttings form with value changes subscription refactor: remove some unnecessary pipes for graphql queries and mutations fix: required control label update from form wrapper when no label is set in the html
…es fix: notification snackbar messages and callback trigger on success and error, as success message was always set even with errors, so add success snackbar to callback method feat: update notification methods to trigger snackbar messages from the related service fix: group list translations plus refactor some methods to remove subscriptions within subscriptions fix: all role list load when add/remove/edit one inside an application, plus refactor some methods to remove subscriptions within subscriptions
…es fix: resources search button and grid update on property change for form builder feat: add missing unsubscriptions for all the logic related to the question types in the survey forms feat: update some question interfaces with new properties regarding the aforementioned reason
|
@AntoineRelief Changes made set in the description and in the related ticket KR, Unai |
|
@unai-reliefapp |
Yes, i'll create another branch for the error handler using same ticket number if it's okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed, among other minor issues:
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots
Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145