Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gamecube has this:
Must use version 2407-68 or newer.
so probably should i add
or
Must use version 2.4-225 or newer.
why?
well, at this time flycast started to actually send the correct headers (commit for reference)
i was going to put 2.4, but i don't know if this can confuse users with the git tag release from github, with that site users will download an old version...
i think flycast uses
version-build number or minor-commit
, so if you check the workflow from the commit, people should usev2.4-225
or newer (https://github.com/flyinghead/flycast/actions/runs/13564228706/job/37913605590 check upload symbols to Sentry)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jamiras
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.4 is correct, but as best as I can tell, Flycast is currently sending a version number of 1.0:
This should probably be fixed in Flycast itself.