Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Microsoft.Extensions.ApiDescription.* to 8.0.14 #5121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ntyrrell
Copy link

Upgraded Microsoft.Extensions.ApiDescription.Server & Microsoft.Extensions.ApiDescription.Client to 9.0.3

This would update the runtime dependencies (which are still dependent on AspNetCore 6.0.3) as well as the following bugfixes for Microsoft.Extensions.ApiDescription.Server:
Fix up packaging for Extensions.ApiDescription.Server
Fixes for OpenAPI document generation with M.E.ApiDescription.Server
Upgrade to Microsoft.OpenApi 2.x and support OpenAPI v3.1
#59749 move TrimEnd after path normalization
And the following for Microsoft.Extensions.ApiDescription.Client:
#59749 move TrimEnd after path normalization
Fix duplicate add of items to Compile on Microsoft.Extensions.ApiDescription.Client.targets

@lahma
Copy link
Collaborator

lahma commented Mar 17, 2025

I think you can get these also by just referencing the latest versions in the consuming project?

@ntyrrell
Copy link
Author

I think you can get these also by just referencing the latest versions in the consuming project?

Sure, but I don't think that it's unreasonable for this project to reference the most up-to-date version.

It also puts more onus on the consumer of this library to have to maintain an additional dependency.

@RicoSuter
Copy link
Owner

Not sure whether this is a good idea, i think this might break e.g. .NET 8 users...
Isnt this package's version defined by the host application?

@lahma
Copy link
Collaborator

lahma commented Mar 29, 2025

My intuition would say that lowest non-vulnerable LTS would be a good approach, like 8.0.0. Some corporates might get confused if they are tied to say NET 8 LTS and 9.x dependencies start to show up.

@RicoSuter
Copy link
Owner

Thats probably a feasible approach.. (.net 8)
I think this apidescription stuff will be anyway deprecated longterm..

@ntyrrell
Copy link
Author

Thanks for the feedback. I'll adjust it to 8.0.* (not sure what the latest patch number is off hand)

@ntyrrell ntyrrell changed the title Upgraded Microsoft.Extensions.ApiDescription.* to 9.0.3 Upgraded Microsoft.Extensions.ApiDescription.* to 8.0.14 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants