feat: add writeMulti option for yaml #1894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
punkle
approved these changes
Apr 8, 2025
|
thx for the review. i don't think the failing test is mine |
|
@roelarents Ill rerun it. |
|
another try? |
|
@roelarents could you try to update to the main branch and see if it fixes it for you? |
roelarents
force-pushed
the
yaml-write-multidoc
branch
from
8b05e57 to
6234f2e
Compare
fearphage
reviewed
Apr 8, 2025
| @@ -87,7 +96,11 @@ export function createYamlJSONataTransformAction(): TemplateAction<{ | |||
| if (ctx.input.as === 'object') { | |||
| resultHandler = rz => rz; | |||
| } else { | |||
| resultHandler = rz => YAML.stringify(rz, ctx.input.options); | |||
| if (ctx.input.writeMulti) { | |||
There was a problem hiding this comment.
MINOR: A ternary would be a bit more concise here and match the implementation in the handler below.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML util actions could load multidoc YAML (with
loadAll) but not write it yet. Added an optionwriteMultito write an array as multidoc (---) YAML.✔️ Checklist
yarn changesetin the root)