-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: navigable workspace list through physical keyboard #6282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: navigable workspace list through physical keyboard #6282
Conversation
…eactNative into MA-173-Navigable-workspace-list-through-physical-keyboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey.
I know it's a draft and you might be on the correct path, but left a few comments either way, just so you don't rework too much.
It's your onboarding, so it's expected to make things the way you're used to, but I'm going to give you a few tips here and there, so you can understand our processes.
It's just small details and it shouldn't hurt your line of thought.
…eactNative into MA-173-Navigable-workspace-list-through-physical-keyboard
787dc68
to
412492b
Compare
…eactNative into MA-173-Navigable-workspace-list-through-physical-keyboard
5e63b89
to
33b026e
Compare
33b026e
to
19068b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactor doesn't seem related to the goal of this PR.
It looks good, but it should've been done on a separate one.
…eactNative into MA-173-Navigable-workspace-list-through-physical-keyboard
Proposed changes
These options should be reachable through physical keyboard.

Issue(s)
https://rocketchat.atlassian.net/browse/MA-173
How to test or reproduce
On iOS settings, go to
Accessibility -> Keyboards & Typing -> Full Keyboard Access
and enable it.Screenshots
Types of changes
Checklist
Further comments