Skip to content

feat: navigable workspace list through physical keyboard #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

cardoso
Copy link
Member

@cardoso cardoso commented Mar 31, 2025

Proposed changes

These options should be reachable through physical keyboard.
Screenshot 2025-03-31 at 20 44 44

Issue(s)

https://rocketchat.atlassian.net/browse/MA-173

How to test or reproduce

On iOS settings, go to Accessibility -> Keyboards & Typing -> Full Keyboard Access and enable it.

Screenshots

Android iOS
Clipboard-20250401-210710-677 Simulator Screen Recording - iPhone 16 - 2025-04-01 at 10 37 09

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey.
I know it's a draft and you might be on the correct path, but left a few comments either way, just so you don't rework too much.

It's your onboarding, so it's expected to make things the way you're used to, but I'm going to give you a few tips here and there, so you can understand our processes.

It's just small details and it shouldn't hurt your line of thought.

@cardoso cardoso force-pushed the MA-173-Navigable-workspace-list-through-physical-keyboard branch from 787dc68 to 412492b Compare April 9, 2025 22:47
@cardoso cardoso force-pushed the MA-173-Navigable-workspace-list-through-physical-keyboard branch from 5e63b89 to 33b026e Compare April 11, 2025 21:04
@cardoso cardoso force-pushed the MA-173-Navigable-workspace-list-through-physical-keyboard branch from 33b026e to 19068b9 Compare April 11, 2025 21:12
@cardoso cardoso marked this pull request as ready for review April 11, 2025 21:29
@cardoso cardoso self-assigned this Apr 11, 2025
@cardoso cardoso requested a review from diegolmello April 11, 2025 21:41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor doesn't seem related to the goal of this PR.
It looks good, but it should've been done on a separate one.

…eactNative into MA-173-Navigable-workspace-list-through-physical-keyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants