Fix menu breaking when Roo is moved between primary and secondary sidebars #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebars Hello Roo Team! We changed this on the Kilo side and thought it might be useful to you! The menu buttons (Settings etc.) stop working when Roo is moved between the primary and secondary sidebars. This is because ClineProvider is prematurely disposed in that case This change prevents the ClineProvider from being disposed when hosted in a sidebar. It should still be disposed when hosted in a tab, because they have their own ClineProvider instance. Found while investigating Kilo-Org/kilocode#502.
hannesrudolph
added
the
Issue/PR - Triage
daniel-lxs
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
reviewed
May 28, 2025
daniel-lxs
reviewed
May 28, 2025
dosubot
bot
added
the
size:S
daniel-lxs
moved this from PR [Needs Preliminary Review]
to PR [Needs Review]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
chrarnoldus
deleted the
christiaan/dont-dispose-singleton-clineprovider-roo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello Roo Team! We changed this on the Kilo side and thought it might be useful to you!
The menu buttons (Settings etc.) stop working when Roo is moved between the primary and secondary sidebars. This is because ClineProvider is prematurely disposed in that case.
This change prevents the ClineProvider from being disposed when hosted in a sidebar. It should still be disposed when hosted in a tab, because they have their own ClineProvider instance.
Found while investigating Kilo-Org/kilocode#502.
Test Procedure
Type of Change
Important
Fixes menu button functionality by preventing premature disposal of
ClineProviderwhen Roo is moved between sidebars.ClineProviderfrom being disposed when in sidebar mode inClineProvider.ts.ClineProvideris disposed only in tab mode.ClineProvider.ts.This description was created by
for 323fce8. You can customize this summary. It will automatically update as commits are pushed.