[reopen] Scroll position in content #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that this is needed can't you just extend CodeEditor and Content classes? |
|
That's exactly what I did for my project, it's just a proposal and can be rejected if it doesn't fit sora's design principles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(reopen #661 )
I'm not sure if it's a good decision to have scroll position in Content in terms of architecture, but in my case it works well.
I want to be able to save the scroll position in the database so that when I reopen the app, the file will automatically be opened at the previous scroll position. I've already tested this behavior in my app and it works well (commit)