Refactored to use implicit insert and remove insert_type method from context object #3395 #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the context object (Rust-GCC#3395) gcc/rust/ChangeLog: * typecheck/rust-substitution-mapper.cc: Refactored code to use insert_implicit_type instead of insert_type. * typecheck/rust-hir-type-check.h: Removed declaration of insert_type from TypeCheckContext class. * typecheck/rust-typecheck-context.cc: Removed definition of insert_type. Signed-off-by: sasa630 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution resolves issue #3395 by refactoring the code to use implicit_insert_type instead of insert_type, improving clarity and eliminating the insert_type method from the context object.
Changed files:
-typecheck/rust-substitution-mapper.cc: Updated to use insert_implicit_type instead of insert_type.
-typecheck/rust-hir-type-check.h: Removed the insert_type declaration from the TypeCheckContext class.
-typecheck/rust-typecheck-context.cc: Removed the insert_type definition.