Skip to content

Added CI Job for linting Markdowns #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Added CI Job for linting Markdowns #41

wants to merge 4 commits into from

Conversation

0101coding
Copy link

This allows all Markdowns to have proper linting before they are pushed to the repository.
This is to resolve Issue #40

0101coding
0101coding commented Aug 19, 2022
View reviewed changes
Copy link
Author

@0101coding 0101coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed issues related to linting of the rust file

@John15321
Copy link
Contributor

Why is a rust file edited here?

@John15321
Copy link
Contributor

Please add a placeholder in the ci config for adding warnings to ignore

@0101coding
Copy link
Author

Why is a rust file edited here?

The file was edited because of failed linting from clippy

@0101coding
Copy link
Author

Please add a placeholder in the ci config for adding warnings to ignore

Ok.

@John15321
Copy link
Contributor

Why is a rust file edited here?

The file was edited because of failed linting from clippy

Oh that's because you are branching from main to main. Im sorry I know I haven't done the contribution section in the readne. But please branch from develop to develop. Change the target to develop and we will work with that

@0101coding
Copy link
Author

Why is a rust file edited here?

The file was edited because of failed linting from clippy

Oh that's because you are branching from main to main. Im sorry I know I haven't done the contribution section in the readne. But please branch from develop to develop. Change the target to develop and we will work with that

Got it

@John15321
Copy link
Contributor

Why is a rust file edited here?

The file was edited because of failed linting from clippy

Oh that's because you are branching from main to main. Im sorry I know I haven't done the contribution section in the readne. But please branch from develop to develop. Change the target to develop and we will work with that

Got it

CI on develop is fine. So delete your changes to any rust files. And rust rebase the branch or ignore the formatting CI

@John15321 John15321 added documentation Improvements or additions to documentation CI/CD labels Aug 19, 2022
@John15321 John15321 linked an issue Aug 19, 2022 that may be closed by this pull request
Add Markdown Linting CI Job #40
Open
@0101coding 0101coding closed this Aug 19, 2022
@0101coding 0101coding deleted the Markdown-linting branch August 19, 2022 14:09
@0101coding 0101coding mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0101coding 0101coding

Labels
CI/CD documentation Improvements or additions to documentation
Projects
None yet
Milestone
📃 Documentation
Development

Successfully merging this pull request may close these issues.

Add Markdown Linting CI Job
2 participants
@0101coding @John15321