remove target override for bindgen because it isn't necessary #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
reviewed
Apr 2, 2025
There was a problem hiding this comment.
So, this seems perfect, correct and builds on my xcode 16.0 without the errors shown in the rust-bindgen PR. The part that's unclear to me is if it works as expected with older versions of clang/xcode.
Admittedly, there's not a policy of "oldest xcode supported" on this project but I'm anxious about broken builds for people on xcode 15 or something.
|
Ideally, we'd wait for rust-lang/rust-bindgen#3182 to land, and then add a dependency on the specific patch version that's released in. Then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
aarch64-apple-ios-simwon't build with the error:I have a fix for bindgen, but the workaround in build.rs makes this ineffective.