Skip to content

ml-kem: fix benchmarking code #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2024
Merged

ml-kem: fix benchmarking code #19

merged 2 commits into from
May 30, 2024

Conversation

bifurcation
Copy link
Contributor

Some late changes in #2 appear to have broken the benchmarking code. This PR makes the few small changes needed to get it working again.

@bifurcation bifurcation requested a review from tarcieri May 30, 2024 18:56
@tarcieri
Copy link
Member

It would be good to add cargo build --benches to check the benchmarks build in CI

@bifurcation
Copy link
Contributor Author

Good point @tarcieri. Added such a line.

@tarcieri tarcieri changed the title Fix benchmarking code ml-kem: fix benchmarking code May 30, 2024
@tarcieri tarcieri merged commit 221f217 into master May 30, 2024
13 checks passed
@tarcieri tarcieri deleted the fix-bench branch May 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bifurcation @tarcieri