Skip to content

ssh-key: add a crate feature to allow insecure RSA keys - fixes #336 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Eugeny
Copy link
Contributor

@Eugeny Eugeny commented Feb 24, 2025

@Eugeny Eugeny force-pushed the ssh-key-hazmat-allow-insecure-rsa-keys branch from 901370b to 8dc1cce Compare February 24, 2025 22:15
@Eugeny Eugeny marked this pull request as ready for review February 24, 2025 22:19
@tarcieri
Copy link
Member

It would probably make sense to figure out a common naming convention we can use for rsa and dsa which allows insecure cryptography

@Eugeny
Copy link
Contributor Author

Eugeny commented Feb 25, 2025

I'm fine with it either way. I've chosen the hazmat- prefix as it's used as module name for dangerous stuff elsewhere in RustCrypto (e.g. rsa). I can rename dsa to hazmat-dsa but I think the current name is better as it's in line with other algo features.

@tarcieri
Copy link
Member

Related: RustCrypto/RSA#445

@nbdd0121
Copy link

Using crate features can be dangerous as features are unified, so if one crate enables it it disable this protection for another crate. I think this should be opt-in for each use-site, rather than globally.

@tarcieri
Copy link
Member

Yeah, if we support this it would be better to have an explicit API for it (which could still be feature-gated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants